ATARI environments - part1 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i (NON-vectorized env only)
JulienT01
added
documentation
JulienT01
requested review from
TimotheeMathieu,
AleShi94,
KohlerHECTOR and
mmcenta
for more information, see https://pre-commit.ci
restart test pipeline...
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nto xfail_tests_mac_windows
for more information, see https://pre-commit.ci
mmcenta
approved these changes
Apr 7, 2023
rlberry/agents/torch/utils/models.py
Outdated
| def convolutions(self, x): | ||
| x = x.float() | ||
| if len(x.shape) == 3: | ||
| if ( |
There was a problem hiding this comment.
maybe move this comment to the line above so black doesn't split this into three lines
rlberry/envs/gym_make.py
Outdated
| scalarize = True | ||
|
|
||
| if "atari_wrappers_dict" in kwargs.keys(): | ||
| atari_wrappers_dict = kwargs["atari_wrappers_dict"] |
There was a problem hiding this comment.
You can just do atari_wrappers_dict = kwargs.pop('atari_wrappers_dict') for the same effect.
rlberry/envs/gym_make.py
Outdated
| @@ -32,14 +33,59 @@ def gym_make(id, wrap_spaces=False, **kwargs): | |||
| return Wrapper(env, wrap_spaces=wrap_spaces) | |||
|
|
|||
|
|
|||
| def atari_make(id, scalarize=True, **kwargs): | |||
| def atari_make(id, scalarize=None, **kwargs): | |||
There was a problem hiding this comment.
Why True to None? Shouldn't it be False?
for more information, see https://pre-commit.ci
TimotheeMathieu
approved these changes
Apr 12, 2023
| @@ -32,14 +33,58 @@ def gym_make(id, wrap_spaces=False, **kwargs): | |||
| return Wrapper(env, wrap_spaces=wrap_spaces) | |||
|
|
|||
|
|
|||
| def atari_make(id, scalarize=True, **kwargs): | |||
| def atari_make(id, scalarize=False, **kwargs): | |||
There was a problem hiding this comment.
A small docstring?
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PART1.
Add and update code to train on atari games (DQN and PPO on ALE/Breakout and ALE/Freewy):
TODO part 2 (Other PR) : #285